feat: Add configurable Bedrock retry parameters by Dan-Wuensch · Pull Request #4316 · block/goose

Dan-Wuensch · 2025-08-25T14:53:32Z

Resolves #4173

Changes included:

Configurability of AWS Bedrock retry settings via environment variables
New default retry settings for AWS Bedrock based on observed testing (these help mitigate failures due to running out of retries within the throttling window while don't push it too far)
Add missing Databricks retry settings to providers documentation

Testing steps performed:

AWS Bedrock provider retries using defaults
AWS Bedrock provider retries using set environment variables
Tried Ollama retries using qwen2.5 and qwen2.5-coder, but this is blocked by the in 1.6.0 bug Unsupported operation: streaming not implemented when listing files #4308
Use OpenAI provider

Dan-Wuensch · 2025-08-25T14:54:14Z

I observed the following test is failing, but checked and it is also failing on main:

failures:

---- providers::base::tests::test_provider_metadata_context_limits stdout ----

thread 'providers::base::tests::test_provider_metadata_context_limits' panicked at crates/goose/src/providers/base.rs:564:9:
assertion `left == right` failed
  left: 200000
 right: 128000


failures:
    providers::base::tests::test_provider_metadata_context_limits

taniandjerry · 2025-08-25T15:52:25Z

Awesome job on your first contribution! Let me tag the dev team to take a look ❤️ @DOsinga @michaelneale @alexhancock @zanesq @jamadeo @katzdave

DOsinga · 2025-08-25T16:12:19Z

crates/goose/src/providers/bedrock.rs

    "anthropic.claude-3-5-sonnet-20241022-v2:0",
+    "anthropic.claude-3-7-sonnet-20250219-v1:0",
+    "anthropic.claude-sonnet-4-20250514-v1:0",
+    "anthropic.claude-sonnet-4-20250514-v1:0",


maybe change the default model too?

Does the default Goose install script use latest instead of version pinning?

If so, I worry about disruption to existing users by changing the model since their prompts may work worse (or better!) on a new model. Could require tuning prompt(s) and running evals to adopt in some cases

That upgrade concern probably only applies to pipeline / automatic use cases not desktop CLI/GUI though. Idk what percentage of adoption that represents, and then of course Bedrock would only be a subset of that

What do you think about me logging an Issue for the model update instead, to have that be a separate more visible change?

yeah, we're working on that. right now it is a bit of a mess which model a conversation will use. we're working on making this a real property of the session so that if you change the global settings, it won't change it for existing conversations.

either way, changing the default here, should only change which model is suggested when you select the provider

Ah ok! In that case I'll push up a commit for updating default. Want to use latest Sonnet version?

Dan-Wuensch · 2025-08-25T16:48:35Z

Demo of new default AWS Bedrock model recommendation:

Dan-Wuensch · 2025-08-25T16:50:29Z

Tangential thought: Does BEDROCK_KNOWN_MODELS affect any validation of the user's model entry? We could look at including some models from other vendors than Anthropic at some point. Not a big concern to me as long as it will accept pasting model IDs from outside the list, which it looks like it does to me.

DOsinga · 2025-08-25T17:06:06Z

These are just suggested models. @angelahning is looking into showing the full list in a filterable way

blackgirlbytes · 2025-08-25T17:37:57Z

@Dan-Wuensch there's a DCO check that's failing. Here's how to fix it 😄 https://github.com/block/goose/pull/4316/checks?check_run_id=48836635962

…rock provider Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Dan-Wuensch · 2025-08-25T19:52:34Z

@blackgirlbytes thank you! 🙌 Just force pushed a rebase with the sign-off included for those three commits.

michaelneale · 2025-08-25T20:58:58Z

looking good a cargo fmt and maybe a script/cargo-lint.sh would help to check it is ok -

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Dan-Wuensch · 2025-08-25T21:03:31Z

Good catch! There was a piece in the model list that needed to be reformatted. Pushed up re-formatted now

Dan-Wuensch · 2025-08-26T13:28:56Z

@blackgirlbytes checks and approvals are looking good! Except Semgrep appears to have gotten stuck. What's the next step in the process for these changes? 😄

…e-4173-configurable-bedrock-retry Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Dan-Wuensch · 2025-09-04T12:51:07Z

documentation/docs/guides/environment-variables.md


+### Provider Retries
+
+Configurable retry parameters for LLM providers. 


* main: feat: make tests for rmcp based developer server consistent with former implementation (#4519) worlds simplest logging to see where things are blocked (#3888) docs: update quickstart and install topics (#4378) feat: Add configurable Bedrock retry parameters (#4316) remove localstorage getconfig fallbacks (#4432) chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516) Fix databricks streaming errors (#4506) docs: malware check for uvx and npx extensions (#4508)

* 'main' of github.com:block/goose: docs: add ampersand to link (#4560) Add video link to README for user guidance (#4553) docs: social channels (#4552) feat: simplify navigation, make reload work (#4498) docs: new recipe warning (#4545) Add AGENTS.md for AI coding assistant support (#4539) docs: non-interactive compact now (#4543) fixed css classes and added some accessibility fixes (#4492) feat(acp): Read files (#4531) Add YouTube Short to Auto Visualiser Tutorial (#4536) Fix/settings page (#4520) update to RMCP 0.6.2 (#4523) docs: nested goosehints (#4528) feat: Agent Client Protocol implementation of goose (#4511) feat: make tests for rmcp based developer server consistent with former implementation (#4519) worlds simplest logging to see where things are blocked (#3888) docs: update quickstart and install topics (#4378) feat: Add configurable Bedrock retry parameters (#4316) remove localstorage getconfig fallbacks (#4432) chore(deps-dev): bump electron from 37.2.6 to 37.4.0 in /ui/desktop (#4516)

* main: (43 commits) feat: add auto-compact threshold configuration UI (block#4178) Add container detection to developer extension (block#4559) docs: add ampersand to link (block#4560) Add video link to README for user guidance (block#4553) docs: social channels (block#4552) feat: simplify navigation, make reload work (block#4498) docs: new recipe warning (block#4545) Add AGENTS.md for AI coding assistant support (block#4539) docs: non-interactive compact now (block#4543) fixed css classes and added some accessibility fixes (block#4492) feat(acp): Read files (block#4531) Add YouTube Short to Auto Visualiser Tutorial (block#4536) Fix/settings page (block#4520) update to RMCP 0.6.2 (block#4523) docs: nested goosehints (block#4528) feat: Agent Client Protocol implementation of goose (block#4511) feat: make tests for rmcp based developer server consistent with former implementation (block#4519) worlds simplest logging to see where things are blocked (block#3888) docs: update quickstart and install topics (block#4378) feat: Add configurable Bedrock retry parameters (block#4316) ...

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com> Co-authored-by: angiejones <jones.angie@gmail.com> Signed-off-by: Matt Donovan <mattddonovan@protonmail.com>

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com> Co-authored-by: angiejones <jones.angie@gmail.com> Signed-off-by: HikaruEgashira <hikaru-egashira@c-fo.com>

Dan-Wuensch requested a review from a team as a code owner August 25, 2025 14:53

Dan-Wuensch mentioned this pull request Aug 25, 2025

Add model retry values to config.yaml #4173

Closed

1 task

DOsinga approved these changes Aug 25, 2025

View reviewed changes

The-Best-Codes approved these changes Aug 25, 2025

View reviewed changes

blackgirlbytes approved these changes Aug 25, 2025

View reviewed changes

Dan-Wuensch added 3 commits August 25, 2025 15:51

feat: Add configurable retry parameters and improved defaults for Bed…

bc85a5f

…rock provider Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Format code using cargo fmt for consistency

2f0d517

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

chore: Update default recommended Bedrock model to latest Sonnet

4174002

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Dan-Wuensch force-pushed the feat/issue-4173-configurable-bedrock-retry branch from 05106c4 to 4174002 Compare August 25, 2025 19:51

Cargo fmt

73c9a47

Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Merge branch 'main' of https://github.com//block/goose into feat/issu…

994824b

…e-4173-configurable-bedrock-retry Signed-off-by: Dan Wuensch <dan.wuensch@ncino.com>

Dan-Wuensch force-pushed the feat/issue-4173-configurable-bedrock-retry branch from 3db8773 to 994824b Compare September 3, 2025 15:03

move optional variables to Environment Variables guide

cb72580

angiejones self-assigned this Sep 4, 2025

Dan-Wuensch commented Sep 4, 2025

View reviewed changes

angiejones merged commit 627696a into block:main Sep 4, 2025
11 checks passed

Dan-Wuensch deleted the feat/issue-4173-configurable-bedrock-retry branch September 4, 2025 17:01

This was referenced Sep 9, 2025

chore(release): release version 1.8.0 #4572

Closed

release/1.8.0 #4577

Merged


		### Provider Retries

		Configurable retry parameters for LLM providers.

Conversation

Dan-Wuensch commented Aug 25, 2025

Uh oh!

Dan-Wuensch commented Aug 25, 2025

Uh oh!

taniandjerry commented Aug 25, 2025

Uh oh!

DOsinga Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

Dan-Wuensch Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DOsinga Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

Dan-Wuensch Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dan-Wuensch commented Aug 25, 2025

Uh oh!

Dan-Wuensch commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DOsinga commented Aug 25, 2025

Uh oh!

blackgirlbytes commented Aug 25, 2025

Uh oh!

Dan-Wuensch commented Aug 25, 2025

Uh oh!

michaelneale commented Aug 25, 2025

Uh oh!

Dan-Wuensch commented Aug 25, 2025

Uh oh!

Dan-Wuensch commented Aug 26, 2025

Uh oh!

Dan-Wuensch Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Dan-Wuensch Aug 25, 2025 •

edited

Loading

Dan-Wuensch Aug 25, 2025 •

edited

Loading

Dan-Wuensch commented Aug 25, 2025 •

edited

Loading